status var preview#487
Merged
Merged
Conversation
tomas-villagesql
force-pushed
the
tomas/status-vars-preview
branch
3 times, most recently
from
4d0bda4 to
413f9c4
Compare
tomas-villagesql
force-pushed
the
tomas/status-vars-preview
branch
from
413f9c4 to
7805c40
Compare
malone-at-work
approved these changes
May 15, 2026
| vef_protocol_t max_protocol, | ||
| std::string &error_message); | ||
| vef_protocol_t max_protocol, std::string &error_message, | ||
| const villagesql::services::PopulateContext &ctx); |
Member
There was a problem hiding this comment.
Can we make the context argument first? That is more idiomatic in my experience to have context args, in args, then out args. So also move the protocol in front, while you are at it move the max_protocol before registration.
| // ctx is passed through to on_depopulate for each capability. | ||
| // After this call, the ExtensionRegistration should not be used. | ||
| void unload_vef_extension(const ExtensionRegistration ®istration); | ||
| void unload_vef_extension(const ExtensionRegistration ®istration, |
| static long long g_add_calls = 0; | ||
| static long long g_null_calls = 0; | ||
|
|
||
| static auto g_status_vars = sv::make_capability({ |
Member
There was a problem hiding this comment.
Can we do this as STATIC_VARS to be consistent with how we register other things in the builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move status vars to preview capability